this post was submitted on 09 Dec 2025
1105 points (99.5% liked)
Programmer Humor
27782 readers
1462 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
I've seen some garbage slide through code reviews. Most people don't do them well.
I'm doing contract work at a big multinational company, and I saw a syntax error slide through code review the other day. Just, like, too many parenthesis, the function literally wouldn't work. (No, they don't have automated unit tests or CI/CD. Yes, that's insane. No, I don't have any power to fix that, but I am trying anyway). It's not hard to imagine something more subtle like a memory leak getting through.
In my experience, people don't want to say "I think this is all a bad idea" if you have a large code review. A couple years ago, a guy went off and wrote a whole DSL for a task. Technically, it's pretty impressive. It was, however, in my opinion, wholly unnecessary for the task at hand. I objected to this and suggested we stick with the serviceable, supported, and interoperable approach we had. The team decided to just move forward with his solution, because he'd spent time on it and it was ready to go. So I can definitely see a bunch of people not wanting to make waves and just signing off on something big.